-
Notifications
You must be signed in to change notification settings - Fork 10
[CHERIoT] Add a "cheriot capability" memory/register formatter to LLDB. #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bdc602c to
3072315
Compare
| {eFormatInstruction, 'i', "instruction"}, | ||
| {eFormatVoid, 'v', "void"}, | ||
| {eFormatUnicode8, 'u', "unicode8"}, | ||
| {eFormatCheriotCapability, '\0', "cheriot capability"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does '\0' do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make it 'C' or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It provides a single-character name for the format. \0 is the "none" sentinel. Unfortunately 'c' and 'C' are both taken already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could do something more exotic like '@'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added 'P' as a single character code for it.
|
Cleaned up and added unit tests. |
|
Changed formatting to (mostly) match the formatting in RTOS logging. |
No description provided.